On Thu, 18 Sep 2025 05:42:01 GMT, David Holmes <[email protected]> wrote:

>> ough,
>> yes, should be outside INCLUDE_JVMTI 
>> However, I just can't understand how those methods could be called if JVMTI 
>> is not included. Do we still have any mechanisms to suspend thread without 
>> jvmti nowdays?
>
> No we don't but we are left with a lot of historical code organization. JVMTI 
> is the only client of the `JavaThread::java_suspend/java_resume` API but that 
> code already existed independent of JVMTI. The current INCLUDE_JVMTI guards 
> are what is needed to make a non-JVMTI configuration build. If we were so 
> inclined we could push those guards right up to JavaThread and then exclude 
> compiling files like `suspendResumeManager.cpp`.

Except the notion of "suspend" permeates the handshake code and is impossible 
to disentangle.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27317#discussion_r2357624527

Reply via email to