On Thu, 18 Sep 2025 03:35:19 GMT, Ioi Lam <[email protected]> wrote: >> Goal: simplify AOT implementation and removed unnecessary tests: >> >> This PR removes old CDS tests that use java agents during CDS dump (to >> increase test coverage by triggering conditions, such as GCs, that were not >> happening during usual `java -Xshare:dump` operations). >> >> Since AOT assembly is much more complex now, we have enough coverage. These >> old tests are no longer necessary. >> >> With these tests removed, we no longer need the >> `-XX:-AllowArchivingWithJavaAgent` diagnostic flag, which has been abused by >> users despite the warning that this flag should not be used in production. > > Ioi Lam has updated the pull request with a new target base due to a merge or > a rebase. The pull request now contains three commits: > > - Merge branch 'master' into > 8362561-remove-diagnostic-option-AllowArchivingWithJavaAgent > - Added test case for dynamic archive with -javaagent > - 8362561: Remove diagnostic option AllowArchivingWithJavaAgent
Looks reasonable. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27304#pullrequestreview-3237906570
