On Fri, 17 Oct 2025 02:04:55 GMT, David Holmes <[email protected]> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with 10 
>> additional commits since the last revision:
>> 
>>  - c++
>>  - cc
>>  - simplfiy
>>  - mv to attach
>>  - revert
>>  - debug
>>  - backslash
>>  - quote
>>  - revert
>>  - wip
>
> test/hotspot/jtreg/serviceability/EarlyDynamicLoad/libEarlyDynamicLoad.c line 
> 48:
> 
>> 46: 
>> 47:     char cmd[256];
>> 48:     snprintf(cmd, sizeof(cmd), "%s %d help", jcmd_path, PID());
> 
> Why are you running the help command instead of `agent_load` ???

See my [earlier 
comment](https://github.com/openjdk/jdk/pull/27766/#issuecomment-3413186002), 
I'm debugging failures on Windows so my code isn't in a reviewable state. Thus 
why I marked the PR as draft.

I'll make it ready again as soon as I fix the tests on Windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27766#discussion_r2438756587

Reply via email to