On Wed, 22 Oct 2025 04:47:22 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/serviceability/jvmti/events/FieldAccess/FieldsEventsFromJNI/libJvmtiFieldEventsFromJNI.cpp > line 167: > >> 165: >> 166: JNIEXPORT void JNICALL >> 167: Java_FieldsEventsFromJNI_enableEventsAndModifyField( > > Need to rename these as well: `s/FieldsEventsFromJNI/FieldEventsFromJNI/g`. > jvmtiFieldEventsFromJNI/ > jvmtiFieldEventsFromJNI/jvmtiFieldEventsFromJNI.java > jvmtiFieldEventsFromJNI/libJvmtiFieldEventsFromJNI.jcpp It seems the file names are still not right and do not follow the above patterns: - FieldsEventsFromJNI/FieldsEventsFromJNI.java - FieldsEventsFromJNI/libJvmtiFieldEventsFromJNI.cpp To follow the above this needs to be applied to folder and Java file names: `s/FieldsEventsFromJNI/FieldEventsFromJNI/g` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27584#discussion_r2450437918
