On Wed, 29 Oct 2025 04:07:38 GMT, Leonid Mesnik <[email protected]> wrote:

>> SendaoYan has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove unnecessary try/catch and loop
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GarbageCollectionStart/gcstart002.java
>  line 66:
> 
>> 64:         try {
>> 65:             for (int i=0; i<ITERATIONS; i++)
>> 66:                 ClassUnloader.eatMemory(); // provoke garbage collecting
> 
> The loop and try//catch are not needed anymore.

Thanks, the try/catch has been removed.

> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP12/ap12t001.java
>  line 75:
> 
>> 73:         // Provoke OutOfMemoryError in order to clear all soft references
>> 74:         for (int i= 0; i < GC_TRYS; i++)
>> 75:             ClassUnloader.eatMemory();
> 
> loop is not needed, I think

The loop and the loop count variable GC_TRYS has been removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28011#discussion_r2471881952
PR Review Comment: https://git.openjdk.org/jdk/pull/28011#discussion_r2471882069

Reply via email to