On Tue, 28 Oct 2025 23:18:48 GMT, Ruben <[email protected]> wrote: >> The C2 exception handler stub code is only a trampoline to the generated >> exception handler blob. This change removes the extra step on the way to the >> generated blob. >> >> According to some comments in the source code, the exception handler stub >> code used to be patched upon deoptimization, however presumably these >> comments are outdated as the patching upon deoptimization happens for >> post-call NOPs only. > > Ruben has refreshed the contents of this pull request, and previous commits > have been removed. The incremental views will show differences compared to > the previous content of the PR. The pull request contains three new commits > since the last revision: > > - Address review comments and fix a mistype > - Check for NOP and MOVK separately in NativePostCallNop > - Test for deoptimization in virtual threads > > Change-Id: I9ef51b426d34e9b44a3891f6a45307232f900e5a
Tests have passed on SAP supported platforms and the fix I for the aarch64 issue which I had seen looks correct. Looks like the `NativePostCallNop` verification issue is not only related to the removal of the exception handler stubs. Shouldn't it be addressed in a separate issue? This PR is already large. And backports may also play a role. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26678#pullrequestreview-3398589460
