On Fri, 31 Oct 2025 17:33:33 GMT, Kevin Walls <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use stderrShouldBeEmptyIgnoreVMWarnings
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java
> line 97:
>
>> 95:
>> 96: private boolean isValidFrame(Address nextCFA, boolean isNative) {
>> 97: // CFA should not be null even if it is Java frame.
>
> This comment means a Java interpreter frame need not have a different
> CFA/frame pointer?
>
> "native" means we found DWARF. Non-native means Java interpreted or Java
> compiled.
> Java frames just need a non-null CFA.
>
> // CFA should never be null.
> // nextCFA must be greater than current CFA, if frame is native.
> // Java interpreter frames can share the CFA (frame pointer).
Exactly. I updated the comment. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27885#discussion_r2483054834
