On Tue, 23 Sep 2025 04:22:49 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Johan Sjölen has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/operands-again' into operands-again >> - Fix BSM naming > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java > line 482: > >> 480: int basePos = offs.at(bsmIndex); >> 481: int argv = basePos + INDY_ARGV_OFFSET; >> 482: int argc = getBootstrapMethodArgsCount(bsmIndex); > > Nit: Consider to make it shorter: > `getBootstrapMethods` => `getBSMs` > `getBootstrapMethodArgsCount` => `getBSMArgsCount` I'm keeping it verbose, as that's the general style of this file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2489941288
