On Tue, 11 Nov 2025 12:37:57 GMT, Anton Artemov <[email protected]> wrote:
>> src/hotspot/share/runtime/objectMonitor.cpp line 533:
>>
>>> 531: }
>>> 532:
>>> 533: void ObjectMonitor::enter_with_contention_mark(JavaThread* current,
>>> ObjectMonitorContentionMark &cm, bool post_jvmti_events) {
>>
>> In the baseline also: `cm` is passed in, but it only used for this:
>> `assert(cm._monitor == this, "must be");`.
>>
>> This makes me wonder if we're missing some code in
>> `enter_with_contention_mark`
>> that is normally done when we are passed an `ObjectMonitorContentionMark`.
>
> Yes, in `enter_with_contention_mark` the mark itself is only for assertion. I
> agree that is not clear, if there is any issue popping up, we can address it
> in a separate PR.
I took another look and since we don't do anything with `DEFLATER_MARKER`
in this code path, I concur that we are not missing any code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2519150311
