On Thu, 13 Nov 2025 12:53:50 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> We've fixed mixed mode jstack for the debuggee running with `-Xcomp` in 
>> [JDK-8370176](https://bugs.openjdk.org/browse/JDK-8370176), but it was not 
>> enough. We need to handle like unifying `CFrame` and `Frame` in stack 
>> unwinding as possible, and need to change how to get caller SP/FP from stack.
>> 
>> This PR works fine on both Linux AMD64 and Linux AArch64. All of 
>> `hotspot/jtreg/serviceability/sa` tests have been passed on both platforms.
>> 
>> Big thanks to @pchilano for your help!
>
> Yasumasa Suenaga has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update for Linux PPC64 and RISC-V

Fix looks good to me (can't comment on the PPC and RISCV parts though).

test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixedWithXComp.java line 40:

> 38:  * @requires vm.hasSA
> 39:  * @requires os.family == "linux"
> 40:  * @requires os.arch == "amd64"

Can't we run the test on AArch64 now?

-------------

PR Review: https://git.openjdk.org/jdk/pull/28284#pullrequestreview-3466259361
PR Review Comment: https://git.openjdk.org/jdk/pull/28284#discussion_r2528531491

Reply via email to