On Tue, 18 Nov 2025 14:48:37 GMT, Chen Liang <[email protected]> wrote:
>> ArrayKlass doesn't set AccessFlags so don't look for them there. See CR for >> details. >> Fixed SA and jvmci. @iwanowww Can you check that I changed C2 correctly (we >> talked about this in August). >> Tested with tier1-4. 5-7 in progress. > > src/hotspot/share/oops/constantPool.cpp line 1228: > >> 1226: >> 1227: // Check constant pool method consistency >> 1228: InstanceKlass* callee = InstanceKlass::cast(k); > > I know a MethodRef can be `[I`, `clone`, `()Ljava/lang/Object;` for > `intArray.clone()` Java calls translated by javac. I wonder if this new code > would break for such an array callee class. At one point, I removed is_interface() from class Klass, but then restored it because dependencies uses this a lot and has many Klass parameter types, instead of InstanceKlass. I'll revert this change, but I'm curious why none of the tests failed with this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2538747727
