On Fri, 14 Nov 2025 12:58:33 GMT, Kevin Walls <[email protected]> wrote:
>> Mat Carter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Document use of DiagnosticCommand > > src/hotspot/share/services/diagnosticCommand.cpp line 991: > >> 989: } >> 990: >> 991: #if INCLUDE_CDS > > A simple style nit-pick: Error! > The JVM doesn't really dramatize problems like that. It tells you there was > an error, and calmly describes the problem after a colon. "Error: " 8-) > > (There are some "Error!" exclamations in java.xml and one has got into > jdk.jfr, but they are unusual.) > > You can tell me that nit-picking is NOT hyphenated if you like. Thank you, we've removed the "!" from "Error: Failed to end recording" and also removed the "Error! " prefix from the other outputs that weren't internal errors ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27965#discussion_r2546768475
