On Fri, 14 Nov 2025 18:25:03 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Mat Carter has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Document use of DiagnosticCommand
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1007:
>
>> 1005: output()->print_cr("Recording ended successfully");
>> 1006: return;
>> 1007: }
>
> I think this should be reversed and message replaced with comment.
>
> if (AOTMetaspace::is_recording_preimage_static_archive()) {
> // Other thread already dumped archive.
> return;
> }
> output()->print_cr("AOT recording ended successfully");
I switched the order, but the error condition stands: we attempted to stop the
recording, but the VM believes the recording is still continuing
Please note that the flag indicates that the recording is stopping/stopped but
the cache may not have been dumped yet
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27965#discussion_r2543974788
