On Mon, 24 Nov 2025 22:57:18 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reformatting compile.cpp > > src/hotspot/share/opto/library_call.cpp line 4100: > >> 4098: // Other types can report the actual _super. >> 4099: // (To verify this code sequence, check the asserts in >> JVM_IsInterface.) >> 4100: if (generate_interface_guard(kls, region) != nullptr) > > BTW why did you decide to change the order of the checks? I noticed that too. It is necessary for correctness now. It is incorrect and unsafe to use generate_interface_guard() on array after this change, because an array klass is not an InstanceKlass. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2558168496
