On Fri, 28 Nov 2025 21:09:24 GMT, Leonid Mesnik <[email protected]> wrote:

>> The AOT allocates objects while holding lock. The jvmti events can't be 
>> posted in such case. The allocation sampling might be just temporary 
>> disabled while AOT objects are allocated. 
>> 
>> I prefer to disable jvmti events for allocation only, not for AOT globally. 
>> If there are more events should be generated during AOT initialization, we 
>> might want to preserve them and post after initialization is completed. 
>> 
>> The existing failure could be reproduced by running tests with jvmti stress 
>> agent and ZGC enabled. Like
>> make run-test JTREG_JVMTI_STRESS_AGENT=debugger=true 
>> TEST=gc/z/TestGarbageCollectorMXBean.java
>> 
>> Note: 
>> I prelaced NoJvmtiVMObjectAllocMark, it was not used. Also it was incorrect. 
>> The 
>> NoJvmtiEventsMark should be set even if jvmti events are not enable for this 
>> thread. Since jvmti events might be enabled just in the middle of the mark.
>
> Leonid Mesnik has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   made jvmti_events_disalber as counter

Looks good.

-------------

Marked as reviewed by eosterlund (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28544#pullrequestreview-3520191286

Reply via email to