On Thu, 20 Nov 2025 23:05:26 GMT, Patricio Chilano Mateo <[email protected]> wrote:
>> How about removing these methods and just have an extra boolean parameter in >> `start/endTransition`? >> https://github.com/pchilano/jdk/compare/JDK-8364343...pchilano:jdk:startEndTransitionsOnly > > I renamed the methods as suggested. I remembered that we separated > ThreadStart/ThreadEnd in 8306028 for future improvements related to JVMTI. > Not sure if that’s still relevant but in any case probably better to leave > that discussion for a separate bug. Given the comment block to define the terms "mount transition" and "unmount transition" then we could go a bit further and make it 6 methods: start/endMountTransition, start/endUnmountTransition, endFirstMountTransition and startLastUnmountTransition. We don't have to do it now, but it would make the use-sites clearer I think. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28361#discussion_r2578388614
