On Fri, 12 Dec 2025 23:37:20 GMT, Ioi Lam <[email protected]> wrote: >> The `DCmdFactory::_enabled` is always set to `true` and there doesn't seem >> to be a reason to set it to `false`. >> >> This PR removes this field and simplified the creation of `DCmdFactory` >> objects. >> >> The related `_hidden` field is also currently not used, but may be used in >> the future when deprecating DCmds, so we leave it unchanged. >> >> Note that now `jmm_GetDiagnosticCommandInfo()` always set >> `dcmdInfo::enabled` to `true` to be compatible with Java code. > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > @kevinjwalls comments
Marked as reviewed by kevinw (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/28794#pullrequestreview-3584868873
