On Thu, 18 Dec 2025 18:56:19 GMT, Patricio Chilano Mateo <[email protected]> wrote:
>> David Holmes has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Greatly simplifed fix to just defer object_deopt whilst in JNI critical >> region >> - Merge branch 'master' into 8369515-jni-critical >> - Revert "8369515" >> >> This reverts commit 3beb23ccbf5adb98d8c6ad404d40c603bbf499dc. >> - 8369515 > > src/hotspot/share/runtime/javaThread.cpp line 1057: > >> 1055: // We mustn't block for object deopt if the thread is >> 1056: // currently executing in a JNI critical region, as that >> 1057: // can cause deadlock because the GCLocker is held. > > I think the last part of the comment might be confusing because it's the > deopt suspender that helds the lock waiting for this thread to exit the > critical region > [[1]](https://github.com/openjdk/jdk/blob/0b2712400b55d4a512db225d090c2f06f01f7f1f/src/hotspot/share/gc/shared/gcLocker.cpp#L108). > Maybe "... cause deadlock because the suspender may allocate and block > waiting for this thread to exit the critical region"? I have reworded and expanded the last part. Thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28779#discussion_r2633282213
