On Fri, 26 Dec 2025 07:10:03 GMT, Jie Fu <[email protected]> wrote: >> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix year >> - Move DockerTestUtils.checkCanTestDocker() inside MetricsTester > > test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java line 86: > >> 84: >> 85: public static void main(String[] args) throws Exception { >> 86: DockerTestUtils.checkCanTestDocker(); > > Thanks for the update. > > Can you explain why here requires docker service directly? > > From the logs in JBS, I guess the places should be where the following docker > files are required? > > Unable to open : > /sys/fs/cgroup/cpu,cpuacct/system.slice/sshd.service/cpu.cfs_period_us > Unable to open : > /sys/fs/cgroup/cpu,cpuacct/system.slice/sshd.service/cpu.cfs_quota_us > Unable to open : /sys/fs/cgroup/cpu,cpuacct/system.slice/sshd.service/cpu.stat
I think this test fails because the cpuset in unmounted. So I updated the JBS titile and comments. And I added check 'cpu period' and 'cpu set' available or not before subtest, rather than check the docker service. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28996#discussion_r2650463886
