On Fri, 19 Dec 2025 11:18:00 GMT, Kevin Walls <[email protected]> wrote:
> In JDK-8370731 I made this test much too thorough. It was good to ensure > some testing was always done, but fixing the existing loop within runOne() > was wrong. We have an outer loop already in the run() method. > > 20, 30 or 137 (!) iterations is unnecessary. Eventually or occasionally an > iteration does not cause a collection. > Limiting to 5 iterations. > > This depends on the change in https://github.com/openjdk/jdk/pull/28876/files > to use "-iterations=" consistently like (a few) other tests. > > Tests that do some allocation and check for a collection can be unreliable. > This may also benefit from what is proposed in > https://github.com/openjdk/jdk/pull/28891 > > I'd like to get this change in though, as the test may fail more now than > before. This pull request has now been integrated. Changeset: a1a75ab6 Author: Kevin Walls <[email protected]> URL: https://git.openjdk.org/jdk/commit/a1a75ab6d1ca25fc88be75239670f5a011ea3053 Stats: 23 lines in 5 files changed: 7 ins; 5 del; 11 mod 8373642: Test vmTestbase/nsk/monitoring/GarbageCollectorMXBean/CollectionCounters/CollectionCounters003/TestDescription.java failed Reviewed-by: cjplummer, syan ------------- PR: https://git.openjdk.org/jdk/pull/28923
