On Fri, 9 Jan 2026 20:27:28 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix split pattern for Windows >> - Tweak toFrame() > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java > line 653: > >> 651: private native long lookupByName0(String objName, String symName); >> 652: private native ClosestSymbol lookupByAddress0(long address); >> 653: private native long getFrameBase0(long sp, long pc); > > I don't see getFrameBase0() being implemented or called. It is a garbage when I was struggling 😅 Removed it in new commit. > src/jdk.hotspot.agent/windows/native/libsaproc/sawindbg.cpp line 915: > >> 913: * Signature: (JJJ)[J >> 914: */ >> 915: JNIEXPORT jlongArray JNICALL >> Java_sun_jvm_hotspot_debugger_windbg_WindbgDebuggerLocal_getSenderRegs0 > > Some comments would be nice. I think what you are doing is getting the two > stack frames starting at the one represented by the incoming registers, and > then getting the registers from the 2nd frame. It would be nice to just make > this clear in a comment,. Added in new commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29019#discussion_r2678195269 PR Review Comment: https://git.openjdk.org/jdk/pull/29019#discussion_r2678192398
