On Sat, 17 Jan 2026 04:05:14 GMT, SendaoYan <[email protected]> wrote:
> Hi all,
>
> This PR make 2 changes which make test more rubustness:
>
> 1. Add max 10 times tries which removed by JDK-8342659, this will make test
> more steady after JDK-8373945.
> vmTestbase/nsk/jvmti/CompiledMethodUnload/compmethunload001/TestDescription.java
> fails before this PR, run passed after this PR with fastdebug build.
> 2.
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t003.java
> try to invoke thread and do not wailt the thread run finish unload the class
> immediately. This PR wait util the thread is non alive, and wait more 2
> senonds to make sure the thread exit completely. This will make test more
> robustness, before this PR
> vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t003/TestDescription.java
> fails probability 1/50, after this PR test run all passed 10k times.
>
> Additional testing:
>
> - [ ] All tests touched test by JDK-8373945
test/hotspot/jtreg/vmTestbase/nsk/share/ClassUnloader.java line 262:
> 260: if (isClassLoaderReclaimed()) {
> 261: System.out.println("ClassUnloader: class loader has been
> reclaimed.");
> 262: Runtime.getRuntime().gc();
It's not clear to me why this gc() is even needed after the WhiteBox gc()
calls. What does it do that we haven't already accomplished with WhiteBox gc()?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29285#discussion_r2701332698
