On Tue, 20 Jan 2026 11:51:20 GMT, Jatin Bhateja <[email protected]> wrote:
>> test/jdk/jdk/incubator/vector/IntVectorMaxTests.java line 68:
>>
>>> 66: static IntVector bcast_vec = IntVector.broadcast(SPECIES, (int)10);
>>> 67:
>>> 68: static void AssertEquals(int actual, int expected) {
>>
>> There are lots of changes in this file that do not seem to have anything to
>> do with Float16. Please file them separately. It will make review much
>> easier.
>
> I have added an assertion wrapper so that float16 values (short) can be
> converted to float before calling actual Assert.* routines to handle all
> possible NaN bit patterns. Since the tests are generate from common template
> hence these changes appear.
Can we not do those changes in a separate change, please? It will make it
easier to review the rest of the PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r2711675095
