On Wed, 28 Jan 2026 20:21:59 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Add new function to handle vDSO
>> - Remove unneeded change
>> - Remove 32 bit support
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 702:
>
>> 700: if (strcmp("linux-vdso.so.1", lib_name) == 0 ||
>> 701: strcmp("linux-vdso64.so.1", lib_name) == 0) {
>> 702: struct utsname uts;
>
> It might be more readable if all the new code below this point was in a new
> function, but I'll leave it up to you to decide if it is worth doing.
Separated them as new function in new commit.
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 709:
>
>> 707: = "vdso64.so";
>> 708: #else
>> 709: = "vdso32.so";
>
> Do we need 32 bit support? I though it was already dropped.
Removed it in new commit to support 64 bit only.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29400#discussion_r2739339771
PR Review Comment: https://git.openjdk.org/jdk/pull/29400#discussion_r2739338255
