On Tue, 17 Feb 2026 04:12:07 GMT, David Holmes <[email protected]> wrote:
>> Albert Mingkun Yang has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - copyright
>> - review
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/CompiledMethodUnload/compmethunload001.java
> line 98:
>
>> 96: // BackgroundCompilation is on by default so wait for compiler
>> threads
>> 97: // to drop references to the to-be-unload class.
>> 98: if (!clsUnLoader.unloadClassAndWait(10_000)) {
>
> Why 10_000 when the implicit timeout was 10 * 100 ?
The previous timeout was probably insufficient -- [Test
vmTestbase/nsk/jvmti/CompiledMethodUnload/compmethunload001/TestDescription.java
is still failing](https://bugs.openjdk.org/browse/JDK-8376547).
Now that the timeout is specific to this test, we can use a somewhat larger
value, without affecting other tests using `ClassUnloader`. (The value 10s was
suggested by Chris Plummer. Can revise if there are better alternatives.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29735#discussion_r2815397768
