On Wed, 18 Feb 2026 17:59:17 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Should not initialize state in DW_CFA_remember_state
>
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 206:
> 
>> 204:       case 0x0a: // DW_CFA_remember_state
>> 205:         remember_state.push(_state);
>> 206:         init_state(_state);
> 
> Is doing an `init_state()` correct here? It's not clear from the spec that 
> DW_CFA_remember_state invalidates the current state.

Good catch! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29779#discussion_r2825044759

Reply via email to