Some small QOL improvement and trivial fixes:
- System.dump_map now takes the filename as a positional argument, which makes 
for less awkward handling
- System.dump_map now allows %t as a placeholder in its filename, and the 
default filename now contains a timestamp (reusing the logic in `make_log_name` 
for this)
- `make_log_name` returns a C-heap allocated array and therefore should not 
return a `const char*` but a `char*`.
- Used the more common - in our code base - `_WINDOWS` instead of `_WIN64`
- Removed the "(linux, Windows and MacOS only)" output since this code never 
runs on other platforms (not compiled for AIX or *BSD)
- since the filename argument has a default value if omitted by the user, it 
can never be empty - assert that instead of doing runtime checks

-------------

Commit messages:
 - file name cannot be empty or null
 - start

Changes: https://git.openjdk.org/jdk/pull/30497/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=30497&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8381314
  Stats: 31 lines in 5 files changed: 8 ins; 5 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/30497.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30497/head:pull/30497

PR: https://git.openjdk.org/jdk/pull/30497

Reply via email to