On Tue, 31 Mar 2026 19:25:54 GMT, Leonid Mesnik <[email protected]> wrote:

>> Shiv Shah has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8338594: Remove standalone -XX:+UsePerfData from native tests and update 
>> copyrights
>
> test/hotspot/jtreg/vmTestbase/nsk/share/aod/AODTestRunner.java line 110:
> 
>> 108:                     // path to java
>> 109:                     argParser.getTestedJDK() + File.separator + "bin" + 
>> File.separator + "java " +
>> 110:                             (classPath != null ? "-classpath " + 
>> classPath + " " : "") +
> 
> better to fail in the line 106 if System.getProperty("test.class.path") is nt 
> set.
> just say explicitly that 
> `System.getProperty("test.class.path")`
> is required. 
> It might happen only if you run test outside of jtreg.

Done. Added null check that throws RuntimeException if test.class.path is not 
set

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30520#discussion_r3018225013

Reply via email to