On Wed, 6 May 2026 11:04:01 GMT, Alan Bateman <[email protected]> wrote:
>> Benjamin Peterson has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - count < max
>> - Merge branch 'master' into BoundedByteArrayOutputStream
>> - 8383909: Unused Threadumper.BoundedByteArrayOutputStream.write(int b) is
>> wrong
>>
>> The condition was inverted.
>
> src/java.base/share/classes/jdk/internal/vm/ThreadDumper.java line 606:
>
>> 604: @Override
>> 605: public void write(int b) {
>> 606: if (max > count) {
>
> Might be mildly better to use `if (count < max)`.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31056#discussion_r3195341438
