On Thu, 7 May 2026 13:37:50 GMT, Matthias Baesken <[email protected]> wrote:

>> There are a couple of tests that do not work well with ubsan - enabled 
>> binaries.
>> Thoe have been identified by Afshin
>> 
>> runtime/ErrorHandling/TestDwarf.java uses artificial division by zero
>> runtime/ErrorHandling/VeryEarlyAssertTest.java uses artificial env var to 
>> crash early in jvm load
>> serviceability/sa/ClhsdbFindPC.java
>> serviceability/sa/ClhsdbCDSCore.java
>> serviceability/sa/ClhsdbPstack.java
>> serviceability/sa/ClhsdbPmap.java
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Move the ubsan check to the core related subtests

Not sure if this is in scope for this PR or the JBS ticket, but would it be 
possible to also remove the following `ATTRIBUTE_NO_UBSAN` and instead mark 
affected tests with `@requires !vm.ubsan` (in case that intentional crashing is 
only done in tests)?
https://github.com/openjdk/jdk/blob/ffc16bd40da6d70d451cf17032cac180a9f7b2f3/src/hotspot/share/prims/unsafe.cpp#L221-L224

Sorry in case this is not in scope and leads the discussion here off-topic.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31035#issuecomment-4400266081

Reply via email to