> The test sees the following output and is supposed to detect the "main[1]" 
> prompt to indicate it is done with the "locals" command that was issued, and 
> then issue a "cont" command:
> 
> [9:13:15.40] Sending command: locals
> [9:13:15.560] reply[0]: Method arguments:
> [9:13:15.561] reply[1]: args = instance of java.lang.String[3] (id=669)
> [9:13:15.561] reply[2]: Local variables:
> [9:13:15.561] reply[3]: main[1]
> [9:13:15.561] Sending command: cont 
> 
> However, the output instead looks like this:
> 
> [21:15:18.114] Sending command: locals
> [21:15:18.515] reply[0]: Method arguments:
> [21:15:18.515] reply[1]: args = instance of java.lang.String[3] (id=686)
> [21:15:18.515] reply[2]: Local variables:
> [21:15:18.515] Sending command: cont
> [21:15:18.716] reply[0]: main[1] > 
> 
> The JdbTest.findPrompt() code looks for a pattern of characters, followed by 
> '[', then a number, then ']'. Unfortunately it matches the String[3] text you 
> see in the output. Because of that the test thought the "locals" command had 
> completed, and issued the "cont" command too soon, which gets the test out of 
> sync.
> 
> Apparently some tests have had this same issue before and a solution was 
> already available. You just need to set compoundPromptIdent to the prompt 
> that the test expects (sans the square brackets part).
> 
> I also fixed a couple of comment typos I noticed in JdbTest while debugging 
> this.
> 
> Tested by running kill003 a couple hundred times on the failing platform and 
> with the failing JVM args.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Chris Plummer has updated the pull request incrementally with two additional 
commits since the last revision:

 - minor comment fix
 - more test fixes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/31048/files
  - new: https://git.openjdk.org/jdk/pull/31048/files/8d108623..49334c1b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=31048&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31048&range=00-01

  Stats: 19 lines in 2 files changed: 11 ins; 1 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/31048.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/31048/head:pull/31048

PR: https://git.openjdk.org/jdk/pull/31048

Reply via email to