On Fri, 8 May 2026 21:56:34 GMT, Ashutosh Mehra <[email protected]> wrote:

>> VM has a hardcoded requirement on the hardware to have support for SSE2. 
>> Without SSE2, VM won't even startup. Therefore there is no need to 
>> explicitly check for SSE2 and/or SSE support, after the initial hardcoded 
>> check for SSE2.
>> This patch clean up the such redundant checks for `supports_sse2()` and 
>> `supports_sse()`.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ashutosh Mehra has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   clflush should always be availble. Remove CPU_FLUSH enum and related
>   asserts and checks
>   
>   Signed-off-by: Ashutosh Mehra <[email protected]>

I see two failures in GHA testing:
1. compiler/c1/Test6579789.java
2. compiler/c1/Test6855215.java

Both these tests use -XX:UseSSE=0 to run the test which is not supported with 
this patch because it updates the range of UseSSE to (2,4). The related bugs 
are https://bugs.openjdk.org/browse/JDK-6579789 and 
https://bugs.openjdk.org/browse/JDK-6855215. From the comments in the bug it 
looks like they happened only with UseSSE<2 which would never happen on x86-64. 
@vnkozlov  I think we can just remove these two tests. Are you ok with that?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31045#issuecomment-4413988631

Reply via email to