On Thu, 14 May 2026 00:33:43 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename to _fde_ptr_encoding
>
> Overall this change looks good. I still need to do some testing.
Thanks @plummercj !
This change also works on Linux AArch64 and lworld branch on valhalla repo.
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 116:
>
>> 114: while (*augmentation_string != '\0') {
>> 115: if (*augmentation_string == 'R') {
>> 116: _encoding = *_buf++;
>
> This is the FDE pointer encoding, right? If so can you name it something like
> fde_ptr_encoding?
Yes, so I renamed it to `_fde_ptr_encoding`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/31085#issuecomment-4446731802
PR Review Comment: https://git.openjdk.org/jdk/pull/31085#discussion_r3238586359
