On Sat, 16 May 2026 07:10:31 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> include order
>
> src/jdk.attach/share/classes/com/sun/tools/attach/spi/AttachProvider.java
> line 182:
>
>> 180: throw new UnsupportedOperationException("Not implemented in
>> base AttachProvider class");
>> 181: }
>> 182:
>
> I looked at the latest API docs for VirtualMachine and AttachProvider and I
> think it will need another round to improve how the overloads are specified.
> For the HotSpot provider we can implNote that invoking the 1-arg attach
> method with an integer id is the equivalent of invoking the 2-arg attach
> method with that id and an empty map. Same thing for AttachProvider. I'll do
> another pass over the docs/wording, which I think is mostly okay, and it's
> just the issues around the overloads to fix before the CSR is finalized.
Thanks, added implNote in AttachProvider.java
HotSpotAttachProvider.java can have a comment as we don't have public api docs
there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3259037082
