On Fri, 15 May 2026 18:01:56 GMT, Vladimir Kozlov <[email protected]> wrote:

>> Manuel Hässig has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 49 commits:
>> 
>>  - Merge branch 'master' into remove-jvmci
>>  - Remove graal from test/langtools
>>  - Remove jvmci and graal from test/lib
>>  - Remove jvmci and graal from test/jdk/jdk/jfr
>>  - Remove jvmci from test/jdk/tools/jlink
>>  - Remove jvmci and graal from test/jdk/jdk/modules
>>  - Remove jvmci and graal frmo test/jdk/java/lang
>>  - Remove graal from test/jdk/javax
>>  - Remove jvmci and graal from test/jdk/com/sun/jdi
>>  - Remove jvmci and graal from test/hotspot/jtreg/runtime
>>  - ... and 39 more: https://git.openjdk.org/jdk/compare/061bd076...0100264f
>
> src/hotspot/share/code/nmethod.cpp line 927:
> 
>> 925:     return nullptr;
>> 926:   }
>> 927:   assert(cont_offset != exception_offset, "continuation offset and 
>> exception offset must be different");
> 
> May be `guarantee` instead of `assert`.

Fixed with f3859009bb3.

> src/hotspot/share/compiler/compiler_globals.hpp line 275:
> 
>> 273:           "mode if posssible")                                          
>>     \
>> 274:                                                                         
>>     \
>> 275:   product(ccstr, CompilationMode, "default",                            
>>     \
> 
> `CompilationMode` flag was added for Graal: 
> https://bugs.openjdk.org/browse/JDK-8227003
> Consider reversing changes as followup RFE.

Filed [JDK-8384834](https://bugs.openjdk.org/browse/JDK-8384834).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30834#discussion_r3257649144
PR Review Comment: https://git.openjdk.org/jdk/pull/30834#discussion_r3257583262

Reply via email to