On Wed, 27 May 2026 14:55:57 GMT, Andrew Dinn <[email protected]> wrote:

>> This patch adds back enum values and strings in cpu feature strings for 
>> `sse` and `sse2` cpu features. JDK-8383881 removed these strings, but there 
>> are numerous tests that use these strings as pre-condition for performing IR 
>> verification. Instead of fixing all these tests, it is much simpler to just 
>> record these features in the cpu feature string.
>> 
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Looks ok to me too but but best to wait on a positive from @reinrich.

@adinn thanks for the review. I will wait for confirmation that it fixes the 
test before integrating.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31284#issuecomment-4555866473

Reply via email to