On Thu, 4 Jun 2026 06:35:44 GMT, David Holmes <[email protected]> wrote:
>> Ivan Bereziuk has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright year
>> - fix more places with tolarance for padding in UL checks
>
> test/hotspot/jtreg/runtime/ClassFile/PreviewVersion.java line 74:
>
>> 72: "-cp", "." + File.pathSeparator +
>> System.getProperty("test.classes"), "PVTest");
>> 73: oa = new OutputAnalyzer(pb.start());
>> 74: oa.shouldMatch("\\[info *\\]\\[class,preview\\] Loading class
>> PVTest that depends on preview features");
>
> Doesn't this need to allow for padding in both parts?
Sure. Correcting. We're touching this line anyway.
I have considered "class,preview" sequence to be "long enough" and so it has a
reasonably small chance of being affected by the potential extra space.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31338#discussion_r3355131845
