On Wed, 3 Jun 2026 14:01:19 GMT, Ivan Bereziuk <[email protected]> wrote:
>> Please review this test enhancement. >> Implemented the padding-tolerant Unified Logging assertions. >> A bunch of Unified Logging assertions do not account for possible extra >> padding in the `[<tags>]` section. >> >> Changed short-tag UL assertions from rigid `shouldContain(...)` to >> `shouldMatch(...)` with patterns like: >> >> \[class,load *\] ... >> >> >> Covered short categories including `class,load`, `nmt`, `pagesize`, `aot`, >> `jni`, `cds`, and `trimnative`. I left remaining `shouldContain()` hits >> alone where the tag set is long enough - `class,resolve`, `verification`, >> `gc,heap,coops`, etc.). >> >> Also updated a couple of existing rigid `shouldMatch()` UL regexes for the >> same padding issue. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ivan Bereziuk has updated the pull request incrementally with two additional > commits since the last revision: > > - update copyright year > - fix more places with tolarance for padding in UL checks Changes requested by dholmes (Reviewer). test/hotspot/jtreg/runtime/ClassFile/PreviewVersion.java line 74: > 72: "-cp", "." + File.pathSeparator + > System.getProperty("test.classes"), "PVTest"); > 73: oa = new OutputAnalyzer(pb.start()); > 74: oa.shouldMatch("\\[info *\\]\\[class,preview\\] Loading class > PVTest that depends on preview features"); Doesn't this need to allow for padding in both parts? ------------- PR Review: https://git.openjdk.org/jdk/pull/31338#pullrequestreview-4425440730 PR Review Comment: https://git.openjdk.org/jdk/pull/31338#discussion_r3353993219
