On Thu, 4 Jun 2026 17:35:29 GMT, Chris Plummer <[email protected]> wrote:

>> Most SA tests rely on the debuggee basically being idle and not doing things 
>> like triggering a GC. Unfortunately this cannot be 100% guaranteed. One 
>> issue is with LingeredApp.main(), which wakes up from sleep every second to 
>> touch the lock file. This could generate a small amount of garbage which 
>> could trigger a GC. This normally never happens, but we were seeing a case 
>> where it did if CDS was disabled. Forcing a GC before the loop seems to fix 
>> the issue.
>> 
>> Tested with svc CI testing in all tiers. Also ran SA tests a large number of 
>> times with and without the fix, and it seems to be reliable.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove ClhsdbInspect from Xcomp problem list

I removed ClhsdbInspect.java from the Xcomp problem list, where is was listed 
under [JDK-8283578](https://bugs.openjdk.org/browse/JDK-8283578). Although the 
failure is basically the same root cause as for this PR (SA tests don't handle 
unexpected GC), I believe the main antagonizer for 
[JDK-8283578](https://bugs.openjdk.org/browse/JDK-8283578) was using -Xcomp 
combined with presence of the code cache sweeper, which is now gone (see 
[JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025)). I was not able to 
reproduce it with the fix for this PR in place.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31355#issuecomment-4624664777

Reply via email to