On Fri, 5 Jun 2026 12:08:15 GMT, Joel Sikström <[email protected]> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Print failure and return
>
> src/hotspot/share/classfile/dictionary.cpp line 262:
> 
>> 260:     stats = sts.done(thread);
>> 261:   }
>> 262:   stats.print(st, table_name);
> 
> It's not immediately obvious that we're printing the initial state of 
> `TableStatistics` if we fail the call to `sts.prepare(thread)`, which fails 
> if we can't take the lock of the CHT.
> 
> Maybe we could add a comment explaining this behavior?

Let's change the output format to print failure if capturing the statistics 
fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31398#discussion_r3362646845

Reply via email to