On Fri, 5 Jun 2026 10:46:20 GMT, Serguei Spitsyn <[email protected]> wrote:

> However, I still have a performance concern which I'd prefer to discuss 
> offline. This potential performance issue held me of this simplification 
> before. My concern is about `PopFrame` related fragment in the function 
> `post_method_exit_inner()`. If stack is big and the `interp_only_mode` has 
> been already enforced for target thread which has and a `FramePop` request 
> then recalculation of current stack depth can give a significant performance 
> overhead. At least, we need to somehow mitigate this issue and measure the 
> performance impact with a specific benchmark test.

We also need to consider how much this feature actually helped. Do we have a 
good understanding of when the stack depth actually remains cached, thus 
avoiding the recalculation? Is this happening in performance critical code? You 
mentioned `FramePop` support. Does the cost of computing the stack depth matter 
when we are debugging?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31389#issuecomment-4633861181

Reply via email to