On Tue, 9 Jun 2026 08:30:19 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Split help text
>
> src/hotspot/share/services/diagnosticCommand.hpp line 760:
>
>> 758: }
>> 759: static const char* description() {
>> 760: return desc;
>
> It is ok to write string literal here instead of defining `desc` .
Thanks for all the notes.
Yes this one I could go either way on. When the string became longer it was
moved to a constexpr in the original PR. That didn't have to be done, there
are other multi-line descriptions. If there's any downside I can go back...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31420#discussion_r3380017600
