On Mon, 22 Jun 2026 15:35:22 GMT, Jorn Vernee <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2822 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8386690: [lworld] cherry-pick JDK-8386124 Test >> serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does >> not match >> >> Reviewed-by: liach >> - 8385743: [lworld] investigate and address build related comments in the >> Valhalla PR >> >> Reviewed-by: liach, erikj >> - 8376346: [lworld] Basic Shenandoah support >> >> Reviewed-by: qamai >> - 8386598: [lworld] C1 acmp profiling fix and minor cleanup >> >> Reviewed-by: mchevalier >> - 8386618: [lworld] Remove unused entry_guard_Relocation >> >> Reviewed-by: chagedorn, jsjolen, jsikstro >> - Merge >> >> Merge jdk-28+2 >> - 8386623: [lworld] Cleanup module support for system modules in JDK >> exploded build with preview resources >> >> Reviewed-by: liach >> - 8386316: [lworld] Replace Valhalla since version with 28 >> >> Reviewed-by: darcy >> - ... and 2812 more: https://git.openjdk.org/jdk/compare/6def7d55...426cc065 > > src/hotspot/share/opto/library_call.cpp line 3191: > >> 3189: >> 3190: Node* map_addr = basic_plus_adr(mirror, field_map_offset); >> 3191: const TypeAryPtr* val_type = >> TypeAryPtr::INTS->cast_to_ptr_type(TypePtr::NotNull)->with_offset(0); > > Is the result of this load (the field map array) treated as stable? Maybe: > > Suggestion: > > const TypeAryPtr* val_type = > TypeAryPtr::INTS->cast_to_ptr_type(TypePtr::NotNull)->with_offset(0)->cast_to_stable(true); > > > I think this would allow folding subsequent loads from the array in > `LoadNode::Value`. I think this is already effectively stable here: https://github.com/openjdk/valhalla/blob/8d024554dcd58d1b019a8d5b89cb6110c4216f2d/src/hotspot/share/classfile/classFileParser.cpp#L1611 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3455506562
