On Sun, 21 Jun 2026 03:43:12 GMT, SendaoYan <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review: removed stale constant
>> - review: fixed two typos in the logging
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java
> line 60:
>
>> 58: }
>> 59: } catch (Throwable t) {
>> 60: log("Failed: PRODUCER caught a trowable: " + t);
>
> Suggestion:
>
> log("Failed: PRODUCER caught a throwable: " + t);
Good catch, thanks. Fixed now
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java
> line 71:
>
>> 69: }
>> 70: } catch (Throwable t) {
>> 71: log("Failed: CONSUMER caught a trowable: " + t);
>
> Suggestion:
>
> log("Failed: CONSUMER caught a throwable: " + t);
Good catch, thanks. Fixed now.
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java
> line 84:
>
>> 82: public static void main(String[] args) throws Exception {
>> 83: try {
>> 84: System.loadLibrary(agentLib);
>
> Since the explicit `System.loadlibary(agentlib)` has been removed, the
> `private static final String agentLib = "VThreadTest";` declaration can be
> removed also.
Good catch. Removed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31581#discussion_r3456584893
PR Review Comment: https://git.openjdk.org/jdk/pull/31581#discussion_r3456586420
PR Review Comment: https://git.openjdk.org/jdk/pull/31581#discussion_r3456594978
