On Wed, 24 Jun 2026 06:56:48 GMT, David Simms <[email protected]> wrote:
>> This is a "*sub-review pull request*" for the first >> [preview](https://openjdk.org/jeps/12) of [JEP 401: Value Classes and >> Objects](https://openjdk.org/jeps/401), specifically >> [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279): Standard library >> implementation of value classes and objects >> >>> [!NOTE] >>> This pull request and the other sub-review pull requests listed below are >>> based on the "*master pull request*" >>> (https://github.com/openjdk/jdk/pull/31120). It contains the same full set >>> of code changes as the "*master pull request*" to preserve the full >>> implementation context; the language compiler, JVM, and standard library >>> changes are intertwined. This separate pull requests exist only to >>> subdivide the review and related discussion by area. >> >> Other areas for review: >> >> - [JDK-8317277](https://bugs.openjdk.org/browse/JDK-8317277): Java language >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31121 >> - [JDK-8317278](https://bugs.openjdk.org/browse/JDK-8317278): JVM >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31122 >> >> Code changes resulting from the review process should be made in >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/). >> >> `valhalla/lworld` is currently updated from `jdk/master` whenever a weekly >> [`jdk` tag](https://github.com/openjdk/jdk/tags) is created. At that time, >> code changes from `valhalla/lworld` will be propagated to the master pull >> request and to all sub-review pull requests, including this one. >> >> Ultimately, review sign-off will be recorded on the "*master pull request*", >> and this pull request will be closed without integration. >> >> This pull request has a large code surface area and often conflicts with >> `jdk/master` on a daily basis. Refer to >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/) for the latest >> state of the project code, keeping in mind that it may lag several days >> behind `jdk/master`. Both repositories may be needed as references during >> review. >> >> # PR implementation description >> >> Here's a high-level overview of what's included here. >> >> ### Core object behaviors >> >> Introduced `Objects` methods to test for identity and `IdentityException` for >> test failures; revised definitions of `==` and `identityHashCode` to work on >> the >> fields of value objects. >> >> - `src/java.base/share/classes/java/lang` >> - `src/java.base/share/classes/java/util` >> - `src/java.base/share/classes/java/lang/runtime` >> - ... > > David Simms has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 2847 commits: > > - Merge branch '8317277' into jep401_sub_review_8317279 > - Merge remote-tracking branch 'valhalla/lworld' into 8317277 > - 8387024: [lworld] Remove the mention of mutexes from the specification > text of value classes > > Reviewed-by: alanb, dholmes, liach > - 8387054: [lworld] BACKOUT JDK-8375694 C2: Dead loop constructed with > CastPP in late inlining > > Reviewed-by: dholmes > - 8386904: [lworld] ProblemList tests that fail due to JDK-8375645 on all > platforms > 8387050: [lworld] ProblemList two > compiler/valhalla/inlinetypes/TestValueClasses.java sub-tests in Xcomp mode > > Reviewed-by: dholmes > - 8386638: [lworld] Port JEP 401 to PPC64 > > Co-authored-by: Richard Reingruber <[email protected]> > Reviewed-by: dbriemann, rrich, lfoltan > - Merge > > Merge jdk-28+3 > - 8386815: [lworld] Reduce the number of constructors in IdentityException > > Reviewed-by: liach, alanb > - 8386626: [lworld] Only enable valhalla IR tests in > ScalarReplacementWithGCBarrierTests.java for aarch64 and x86 > > Reviewed-by: mhaessig, mchevalier > - 8386718: [lworld] C2: Integer overflow in arraycopy scaling for flat arrays > > Reviewed-by: qamai > - ... and 2837 more: https://git.openjdk.org/jdk/compare/915efc50...af3e8048 src/java.base/share/classes/jdk/internal/module/ModulePath.java line 155: > 153: /** > 154: * Returns a ModuleFinder that locates modules in a JDK exploded > image. > 155: * @param modulesDir the modules directory ($JAVA_HOME/modules) Is this is a typo? Should it have been `$JAVA_HOME/jmods`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3467563691
