On Mon, 29 Jun 2026 01:19:36 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> TestJhsdbJstackMixedWithXComp.java fails on Ubuntu 26.04 on Neoverse V1 and 
>> V2 processor.
>> 
>> I introduced DWARF support in mixed jstack in 
>> [JDK-8377946](https://bugs.openjdk.org/browse/JDK-8377946), however I 
>> mentioned it does not support PAC (Pointer Authentication Code) in PR 
>> #29731. It is the reason why TestJhsdbJstackMixedWithXComp.java failed on 
>> Neoverse V1 and V2. They support PAC, and it is enabled on the Kernel on 
>> Ubuntu 26.04 by default.
>> 
>> This PR adds to feature to treat PAC in Linux AArch64. It is Arm-specific 
>> feature, so I separated them in following new classes. It is one of the 
>> reason why this change is bigger.
>> 
>> - AARCH64DwarfParser.java
>> - LinuxAARCH64DebuggerLocal.java
>> - aarch64Dwarf.cpp/hpp (for `DwarfParser` in native)
>> 
>> serviceability/sa tests passed on Linux AMD64, Linux AArch64 (PAC disabled), 
>> and Linux AArch64 (PAC enabled).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Yasumasa Suenaga has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Use print_debug() when encountering unknown DWARF operations
>  - Add onAttach() to LinuxDebuggerLocal to execute platform-dependent process

The changes look good. I'll approve after it passes my testing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/31669#pullrequestreview-4594945718

Reply via email to