On Wed, 1 Jul 2026 22:22:00 GMT, Ashay Rane <[email protected]> wrote:
>> On Windows/ARM64, "jdb -listconnectors" shows "dt_shmem" and not
>> "dt_socket", since both {Sun,Raw}CommandLineLauncher.java prefer
>> "dt_shmem" with a fallback to "dt_socket". This causes the following
>> tests in test/hotspot/jtreg/vmTestbase/nsk to fail:
>>
>> - jdb/options/listconnectors/listconnectors001/listconnectors001.java
>> - jdi/LaunchingConnector/launch/launch001/TestDescription.java
>> - jdi/LaunchingConnector/launch/launch003/TestDescription.java
>> -
>> jdi/LaunchingConnector/launchnosuspend/launchnosuspend001/TestDescription.java
>>
>> This patch fixes the problem by adding entires for "dt_socket" on
>> Windows/ARM64, similar to the exceptions for other platforms.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ashay Rane has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains three additional commits since
> the last revision:
>
> - Merge branch 'master' into JDK-8387625-jdb-dt_socket
> - Fix copyright year
> - Ignore "dt_socket" for Windows/ARM64
>
> On Windows/ARM64, "jdb -listconnectors" shows "dt_shmem" and not
> "dt_socket", since both {Sun,Raw}CommandLineLauncher.java prefer
> "dt_shmem" with a fallback to "dt_socket". This causes the following
> tests in test/hotspot/jtreg/vmTestbase/nsk to fail:
>
> - jdb/options/listconnectors/listconnectors001/listconnectors001.java
> - jdi/LaunchingConnector/launch/launch001/TestDescription.java
> - jdi/LaunchingConnector/launch/launch003/TestDescription.java
> -
> jdi/LaunchingConnector/launchnosuspend/launchnosuspend001/TestDescription.java
> - jdi/ListeningConnector/startListening/startlis001/TestDescription.java
>
> This patch fixes the problem by adding entires for "dt_socket" on
> Windows/ARM64, similar to the exceptions for other platforms.
Looks fine. Technically not trivial, but 24 hours expire in 4 hours, so we can
just wait a bit :)
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/31741#pullrequestreview-4618617128
