On Tue, 30 Jun 2026 11:15:20 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2859 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - Merge >> >> Merge jdk-28+4 >> - 8386963: [lworld] Improve the exception message from Object >> synchronization methods on value objects >> >> Reviewed-by: dholmes, alanb >> - 8387300: [lworld] Minor review comments in javac >> >> Reviewed-by: vromero >> - 8387192: [lworld] Review comment drop for core libs >> >> Reviewed-by: jvernee, vromero >> - 8386999: [lworld] C2: assert(is_dead_loop_safe()) failed: shouldn't be >> cleared yet >> >> Reviewed-by: qamai, vlivanov >> - 8386787: [lworld] >> compiler/valhalla/inlinetypes/TestValueConstruction.java#StressIncrementalInliningDontInlineMyAbstractInit >> timed out >> >> Reviewed-by: phubner, chagedorn >> - 8386995: [lworld] Duplicate value classes are a preview feature warning >> >> Reviewed-by: alanb, vromero >> - 8383389: [lworld] Augment AOTMapLogger::print_oop_details to support flat >> arrays with oops >> >> Reviewed-by: iklam, fparain >> - ... and 2849 more: https://git.openjdk.org/jdk/compare/193de1b1...cdbe55a9 > > src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 50: > >> 48: visible change in the behavior of the class's methods;</li> >> 49: <li>the class performs no synchronization using an instance's >> monitor;</li> >> 50: <li>the class does not declare (or discourages use of) accessible >> constructors;</li> > >> the class does not declare (or discourages use of) accessible constructors; > > Does this apply for value classes that are being proposed in this JEP? As far > as I remember, I haven't seen any text which states or discourages the use of > constructors for value object construction. > > In fact, on the contrary, in one of the review comments in this PR for a > different discussion, it has been rightly pointed out that in recent times > there have been efforts to undeprecate previously deprecated-for-removal > constructors of the primitive wrapper classes. For example > https://bugs.openjdk.org/browse/JDK-8354335. I've filed https://bugs.openjdk.org/browse/JDK-8387749 to track this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3527761282
