On Wed, 8 Jul 2026 08:25:24 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix PlatformSupportImpl due to some internal code review comments. >> - Add similar jps wording. > > src/hotspot/os/linux/os_linux.cpp line 1558: > >> 1556: >> 1557: // Check that any given alternate temporary directory name is is a >> writable directory, >> 1558: // and specifies an absolute path. Revert back to hardcoded /tmp if >> its not an absolute path, but > > Nit: Typos: > - L1557: s/is is/is/ > - L1558: s/if its not/if it is not/ Fixed both of these. > src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c line 267: > >> 265: * Class: sun_tools_attach_VirtualMachineImpl >> 266: * Method: validateSocketFileLength >> 267: * Signature: (I)B > > Nit: The Java declaration is static native `boolean > validateSocketFileLength(String socketPath);`. > Then should it be: `(Ljava/lang/String;)Z`? Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3543948316 PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3543942457
