On Thu, 9 Jul 2026 11:28:15 GMT, Kevin Walls <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> With @kevinjwalls rewrite for getLocalVmId that ignores temp directories.
>> Rewrite tests to actually delete temp files. Fix VirtualMachineImpl to get
>> "unable to access target filesystem" failure and not bypass the same
>> filesystem check.
>
> src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c line 276:
>
>> 274: if (p == NULL) {
>> 275: JNU_ThrowIOException(env, "Socket file path is null");
>> 276: return JNI_FALSE;
>
> Does this need to (conditionally) call ReleaseStringPlatformChars before
> returning?
I don't think so. If p is null JNU_ReleaseStringPlatformChars has nothing to
release.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3551591369
